Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Karthikeyan Ramasubramanian, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51509 )
Change subject: soc/amd/common/block/i2c: Move SoC agnostic parts into common ......................................................................
Patch Set 1:
(13 comments)
File src/soc/amd/common/block/i2c/i2c.c:
https://review.coreboot.org/c/coreboot/+/51509/comment/b6381090_cae58187 PS1, Line 21: trailing whitespace
https://review.coreboot.org/c/coreboot/+/51509/comment/3a4e9e14_0f3013b8 PS1, Line 21: please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/51509/comment/ad307d4e_4429535e PS1, Line 32: trailing whitespace
https://review.coreboot.org/c/coreboot/+/51509/comment/4cf37da4_20a855f3 PS1, Line 44: trailing whitespace
https://review.coreboot.org/c/coreboot/+/51509/comment/acaf7d02_6ec02431 PS1, Line 44: please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/51509/comment/a5eb3afc_240609b9 PS1, Line 60: trailing whitespace
https://review.coreboot.org/c/coreboot/+/51509/comment/3f788605_2cec5b97 PS1, Line 60: please, no spaces at the start of a line
File src/soc/amd/stoneyridge/chip.c:
https://review.coreboot.org/c/coreboot/+/51509/comment/e3cd7f22_42d7f708 PS1, Line 108: dev->ops = &soc_amd_i2c_mmio_ops; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/51509/comment/fd68d155_15c8ead3 PS1, Line 108: dev->ops = &soc_amd_i2c_mmio_ops; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/51509/comment/94c9bfc6_aa6d6292 PS1, Line 109: break; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/51509/comment/a7126516_98367737 PS1, Line 109: break; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/51509/comment/07eb859f_d1d53ad4 PS1, Line 110: } code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/51509/comment/927ebc36_8c67c7bf PS1, Line 110: } please, no spaces at the start of a line