Change in coreboot[master]: mb/google/poppy/variants/nocturne: fix FPMCU IRQ sensitivity
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/27221 )
Change subject: mb/google/poppy/variants/nocturne: fix FPMCU IRQ sensitivity ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/27221/1/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/nocturne/gpio.c:
https://review.coreboot.org/#/c/27221/1/src/mainboard/google/poppy/variants/... PS1, Line 138: NONE
As mentioned in b/78613978#comment10 given this is an active-low interrupt, the pull-down is doing t […]
If signal is active low, why did you change this definition from "_INVERT" ? IF it's a double-mapping issue with kernel, the kernel is where it should be changed, IMO; this file should map to how the hardware actually behaves.
-
Nick Vaccaro (Code Review)