Attention is currently required from: Intel coreboot Reviewers, Jérémy Compostella, Kapil Porwal, Matt DeVillier.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86174?usp=email )
Change subject: soc/intel/common/pmc: Change GPE DW duplicate message to warning
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86174/comment/2e63ad2c_d5050473?usp... :
PS1, Line 9: The message printed when duplicate GPE DW register values
nit: The line length for commit message is 75 characters, it looks like your text editor may not be […]
Acknowledged
File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/86174/comment/9e7b1e76_c5c5dd4d?usp... :
PS1, Line 660: value
values
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86174?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7804ddfa6e067014e034364bd8efbf6efe746cd7
Gerrit-Change-Number: 86174
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Tue, 28 Jan 2025 17:00:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com