Change in coreboot[master]: mb/purism/librem_cnl: Fix HDA verb NID count for Librem Mini
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49106 )
Change subject: mb/purism/librem_cnl: Fix HDA verb NID count for Librem Mini ......................................................................
mb/purism/librem_cnl: Fix HDA verb NID count for Librem Mini
Fix off-by-1 count of NID entries.
Change-Id: I65f70d084022c99233144b460542a793eae2acf3 Signed-off-by: Matt DeVillier matt.devillier@puri.sm --- M src/mainboard/purism/librem_cnl/variants/librem_mini/hda_verb.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/49106/1
diff --git a/src/mainboard/purism/librem_cnl/variants/librem_mini/hda_verb.c b/src/mainboard/purism/librem_cnl/variants/librem_mini/hda_verb.c index c3daf3c..5f410b2 100644 --- a/src/mainboard/purism/librem_cnl/variants/librem_mini/hda_verb.c +++ b/src/mainboard/purism/librem_cnl/variants/librem_mini/hda_verb.c @@ -5,7 +5,7 @@ const u32 cim_verb_data[] = { 0x10ec0269, /* Codec Vendor/Device ID: Realtek ALC293 */ 0x10ec0000, /* Subsystem ID */ - 11, /* Number of entries */ + 10, /* Number of entries */
AZALIA_SUBVENDOR(0, 0x10ec0000), AZALIA_PIN_CFG(0, 0x12, 0x40000000),
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49106 )
Change subject: mb/purism/librem_cnl: Fix HDA verb NID count for Librem Mini ......................................................................
Patch Set 1: Code-Review+2
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49106 )
Change subject: mb/purism/librem_cnl: Fix HDA verb NID count for Librem Mini ......................................................................
Patch Set 1: Code-Review+2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49106 )
Change subject: mb/purism/librem_cnl: Fix HDA verb NID count for Librem Mini ......................................................................
Patch Set 1: Code-Review+2
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49106 )
Change subject: mb/purism/librem_cnl: Fix HDA verb NID count for Librem Mini ......................................................................
mb/purism/librem_cnl: Fix HDA verb NID count for Librem Mini
Fix off-by-1 count of NID entries.
Change-Id: I65f70d084022c99233144b460542a793eae2acf3 Signed-off-by: Matt DeVillier matt.devillier@puri.sm Reviewed-on: https://review.coreboot.org/c/coreboot/+/49106 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Felix Singer felixsinger@posteo.net Reviewed-by: Michael Niewöhner foss@mniewoehner.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/purism/librem_cnl/variants/librem_mini/hda_verb.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/purism/librem_cnl/variants/librem_mini/hda_verb.c b/src/mainboard/purism/librem_cnl/variants/librem_mini/hda_verb.c index c3daf3c..5f410b2 100644 --- a/src/mainboard/purism/librem_cnl/variants/librem_mini/hda_verb.c +++ b/src/mainboard/purism/librem_cnl/variants/librem_mini/hda_verb.c @@ -5,7 +5,7 @@ const u32 cim_verb_data[] = { 0x10ec0269, /* Codec Vendor/Device ID: Realtek ALC293 */ 0x10ec0000, /* Subsystem ID */ - 11, /* Number of entries */ + 10, /* Number of entries */
AZALIA_SUBVENDOR(0, 0x10ec0000), AZALIA_PIN_CFG(0, 0x12, 0x40000000),
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49106 )
Change subject: mb/purism/librem_cnl: Fix HDA verb NID count for Librem Mini ......................................................................
Patch Set 2:
Landed early due to simplicity
-
Angel Pons (Code Review) -
Felix Singer (Code Review)
-
Matt DeVillier (Code Review)
-
Michael Niewöhner (Code Review)