Change in coreboot[master]: tests: Add lib/memset-test test case - coreboot-gerrit

15 Feb 2021


      Attention is currently required from: Martin Roth.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50716 )
Change subject: tests: Add lib/memset-test test case
......................................................................
Patch Set 1:
(1 comment)
File tests/lib/memset-test.c:
https://review.coreboot.org/c/coreboot/+/50716/comment/62d83bf2_a2ab2f9b 
PS1, Line 102: 	memset(&s->base_buffer[MEMSET_BUFFER_SZ / 4], 0xCC, 1);
single byte memset is suspicious. Swapped 2nd/3rd argument?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/50716
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6750caa8ccdc442f78b782407ebfb3af78f476ce
Gerrit-Change-Number: 50716
Gerrit-PatchSet: 1
Gerrit-Owner: jacz@semihalf.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Comment-Date: Mon, 15 Feb 2021 11:13:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment