Attention is currently required from: Furquan Shaikh, Sumeet R Pawnikar, Patrick Rudolph, Aaron Durbin, Karthik Ramasubramanian.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54098 )
Change subject: soc/intel/common: OEM variables support for DPTF
......................................................................
Patch Set 5:
(1 comment)
File src/soc/intel/common/block/acpi/acpi/globalnvs.asl:
https://review.coreboot.org/c/coreboot/+/54098/comment/4e21ccdd_a07ecf4f
PS5, Line 28: ODV0, 8, // Oem Design Variable 0
: ODV1, 8, // Oem Design Variable 1
: ODV2, 8, // Oem Design Variable 2
: ODV3, 8, // Oem Design Variable 3
: ODV4, 8, // Oem Design Variable 4
: ODV5, 8, // Oem Design Variable 5
Why do these have to live in GNVS?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54098
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I79fbf00521d54e66b6cd7d95b026a76fd3a4394b
Gerrit-Change-Number: 54098
Gerrit-PatchSet: 5
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 14 Jun 2021 21:34:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Tim Wawrzynczak (Code Review)