Attention is currently required from: Arthur Heymans.
Nicholas Chin has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/68160?usp=email )
Change subject: util/cbfstool: Add a new mechanism to provide a memory map
......................................................................
Patch Set 8:
(1 comment)
File util/cbfstool/cbfstool.c:
https://review.coreboot.org/c/coreboot/+/68160/comment/53c43869_98777d7d?usp... :
PS8, Line 1974: " [--ext-win-base win-base --ext-win-size win-size] "
I just noticed that you forgot to update the help text here, it still says --ext-win-base today.
Addressed in CB:85619
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68160?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I38ab4c369704497f711e14ecda3ff3a8cdc0d089
Gerrit-Change-Number: 68160
Gerrit-PatchSet: 8
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bao Zheng
fishbaozi@gmail.com
Gerrit-CC: Kapil Porwal
kapilporwal@google.com
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-CC: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Sat, 04 Jan 2025 18:21:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org