Attention is currently required from: Angel Pons, Utkarsh Verma.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74170 )
Change subject: arch/x86/smbios: Fix file formatting ......................................................................
Patch Set 3:
(1 comment)
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/74170/comment/a4b98f04_96516ff0 PS2, Line 216: dimm->serial[1], dimm->serial[2], dimm->serial[3]);
Yes, I understand that and agree with it too. […]
Utkarsh, just to let you know, that clang-format is not used yet in coreboot properly, so it might be too controversial or too much work. Of course, work on improving the situation by updating `.clang-format` is much appreciated. Only you can decide, if you want to open this Pandora’s box.
-
Paul Menzel (Code Review)