Attention is currently required from: Tim Wawrzynczak, Subrata Banik, Meera Ravindranath, Patrick Rudolph. Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54674 )
Change subject: soc/intel/common: Add Alder Lake device IDs ......................................................................
Patch Set 4:
(3 comments)
File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/54674/comment/184ac79f_ce68fcfa PS3, Line 3923: PCI_DEVICE_ID_INTEL_ADL_M_ID_1
don't you need to add this ID into src/soc/intel/common/block/systemagent/systemagent. […]
Yes. Thanks.
File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/54674/comment/d67271cb_b37eddcf PS1, Line 3816: PCI_DEVICE_ID_INTEL_ADL_P_GT2_2
Also consider to add new ID into the required 'C' code else its just a dummy code.
Done
https://review.coreboot.org/c/coreboot/+/54674/comment/1dda7ac6_9aee733c PS1, Line 3914: PCI_DEVICE_ID_INTEL_ADL_M_ID_1
add at line number 3924 so that it doesn't required to adjust the existing code. […]
Done
-
Sumeet R Pawnikar (Code Review)