Attention is currently required from: Arthur Heymans, Felix Held, Jérémy Compostella.
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80335?usp=email )
Change subject: cpu/x86/(sipi|smm): Pass on CR3 from ramstage
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
File src/cpu/x86/mp_init.c:
https://review.coreboot.org/c/coreboot/+/80335/comment/3a19fcbb_664ebc52 :
PS4, Line 366: sp->cr3 = read_cr3();
for consistency reasons i'd also read it in 32 bit mode and populate the struct element
True, page tables can be used for other purposes, such as NX. But then the assembly code should also unconditionally set the CR3 register.
Currently, the code seems consistent with itself, but I don't have a strong preference here. Maybe it makes sense to always program the same CR3 onto the APs as the BSP.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80335?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1250ea6f63c65228178ee66e06d988dadfcc2a37
Gerrit-Change-Number: 80335
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 09 Feb 2024 17:18:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment