Attention is currently required from: Arthur Heymans, Felix Held, Jérémy Compostella.

Patch set 4:Code-Review +2

View Change

1 comment:

• File src/cpu/x86/mp_init.c:

  • Patch Set #4, Line 366: sp->cr3 = read_cr3();

    for consistency reasons i'd also read it in 32 bit mode and populate the struct element

    True, page tables can be used for other purposes, such as NX. But then the assembly code should also unconditionally set the CR3 register.

    Currently, the code seems consistent with itself, but I don't have a strong preference here. Maybe it makes sense to always program the same CR3 onto the APs as the BSP.

To view, visit change 80335. To unsubscribe, or for help writing mail filters, visit settings.