Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42426 )
Change subject: sb/intel/i82801gx,ix,jx: Drop invalid GNVS update routine ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42426/4/src/southbridge/intel/i8280... File src/southbridge/intel/i82801gx/smihandler.c:
https://review.coreboot.org/c/coreboot/+/42426/4/src/southbridge/intel/i8280... PS4, Line 26: /* WAS BROKEN */ What's the purpose here: is that a TODO that the function needs to be filled in with a correct implementation? Is this only overriding a default because even that default behavior isn't needed anymore? As-is, it's hard to figure out what the intent of both the comment and the function is without lots of digging, so please make that clearer.
-
Patrick Georgi (Code Review)