Attention is currently required from: Elyes Haouas.
Julius Werner has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82933?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/nvidia/tegra210/ccplex.c: Remove unused macro ......................................................................
Patch Set 4:
(1 comment)
File src/soc/nvidia/tegra124/spi.c:
https://review.coreboot.org/c/coreboot/+/82933/comment/aa022368_89cc0fcb?usp... : PS1, Line 42: #define SPI_CMD1_MODE_SHIFT 28 Why are you doing this? It is standard when writing drivers to define accessor macros for all registers and bit fields, so you don't have to piece them together one by one whenever you change something. Don't remove hardware definitions just because they're not used.