[S] Change in coreboot[master]: soc/amd: Drop acpi_fill_madt_irqoverride()

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74357 )

Change subject: soc/amd: Drop acpi_fill_madt_irqoverride()
......................................................................

soc/amd: Drop acpi_fill_madt_irqoverride()

It is unused. The use of field irq is problematic as it should
appear relative to IOAPIC GSI bases in the devicetree.

Change-Id: I460fd5fde3a7fba5518ccfc153a266d097a95a39
Signed-off-by: Kyösti Mälkki 
---
M src/soc/amd/cezanne/acpi.c
M src/soc/amd/common/block/acpi/tables.c
M src/soc/amd/common/block/include/amdblocks/acpi.h
M src/soc/amd/glinda/acpi.c
M src/soc/amd/mendocino/acpi.c
M src/soc/amd/phoenix/acpi.c
M src/soc/amd/picasso/acpi.c
7 files changed, 13 insertions(+), 32 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/74357/1

diff --git a/src/soc/amd/cezanne/acpi.c b/src/soc/amd/cezanne/acpi.c
index 9073d8a..a7d1ae7 100644
--- a/src/soc/amd/cezanne/acpi.c
+++ b/src/soc/amd/cezanne/acpi.c
@@ -25,8 +25,6 @@
    current += acpi_create_madt_ioapic_from_hw((acpi_madt_ioapic_t *)current,
    					   GNB_IO_APIC_ADDR);

-	current = acpi_fill_madt_irqoverride(current);
-
    return current;
 }

diff --git a/src/soc/amd/common/block/acpi/tables.c b/src/soc/amd/common/block/acpi/tables.c
index b7c942c..2d409f1 100644
--- a/src/soc/amd/common/block/acpi/tables.c
+++ b/src/soc/amd/common/block/acpi/tables.c
@@ -16,27 +16,6 @@
    return acpi_write_hpet(device, current, rsdp);
 }

-unsigned long acpi_fill_madt_irqoverride(unsigned long current)
-{
-	const struct soc_amd_common_config *cfg = soc_get_common_config();
-	unsigned int i;
-	uint8_t irq;
-	uint8_t flags;
-
-	for (i = 0; i < ARRAY_SIZE(cfg->irq_override); ++i) {
-		irq = cfg->irq_override[i].irq;
-		flags = cfg->irq_override[i].flags;
-
-		if (!flags)
-			continue;
-
-		current += acpi_create_madt_irqoverride((acpi_madt_irqoverride_t *)current, 0,
-							irq, irq, flags);
-	}
-
-	return current;
-}
-
 /* Used by _SB.PCI0._CRS */
 void acpi_fill_root_complex_tom(const struct device *device)
 {
diff --git a/src/soc/amd/common/block/include/amdblocks/acpi.h b/src/soc/amd/common/block/include/amdblocks/acpi.h
index 9ffcb7e..9105184 100644
--- a/src/soc/amd/common/block/include/amdblocks/acpi.h
+++ b/src/soc/amd/common/block/include/amdblocks/acpi.h
@@ -54,7 +54,6 @@
 unsigned long southbridge_write_acpi_tables(const struct device *device, unsigned long current,
    				    struct acpi_rsdp *rsdp);

-unsigned long acpi_fill_madt_irqoverride(unsigned long current);
 void acpi_fill_root_complex_tom(const struct device *device);

uintptr_t add_agesa_fsp_acpi_table(guid_t guid, const char *name, acpi_rsdp_t *rsdp,
diff --git a/src/soc/amd/glinda/acpi.c b/src/soc/amd/glinda/acpi.c
index 31f1c6e..0a6c31b 100644
--- a/src/soc/amd/glinda/acpi.c
+++ b/src/soc/amd/glinda/acpi.c
@@ -27,8 +27,6 @@
    current += acpi_create_madt_ioapic_from_hw((acpi_madt_ioapic_t *)current,
    					   GNB_IO_APIC_ADDR);

-	current = acpi_fill_madt_irqoverride(current);
-
    return current;
 }

diff --git a/src/soc/amd/mendocino/acpi.c b/src/soc/amd/mendocino/acpi.c
index 9370041..899d4c9 100644
--- a/src/soc/amd/mendocino/acpi.c
+++ b/src/soc/amd/mendocino/acpi.c
@@ -26,8 +26,6 @@
    current += acpi_create_madt_ioapic_from_hw((acpi_madt_ioapic_t *)current,
    					   GNB_IO_APIC_ADDR);

-	current = acpi_fill_madt_irqoverride(current);
-
    return current;
 }

diff --git a/src/soc/amd/phoenix/acpi.c b/src/soc/amd/phoenix/acpi.c
index 57e783b..5964e34 100644
--- a/src/soc/amd/phoenix/acpi.c
+++ b/src/soc/amd/phoenix/acpi.c
@@ -27,8 +27,6 @@
    current += acpi_create_madt_ioapic_from_hw((acpi_madt_ioapic_t *)current,
    					   GNB_IO_APIC_ADDR);

-	current = acpi_fill_madt_irqoverride(current);
-
    return current;
 }

diff --git a/src/soc/amd/picasso/acpi.c b/src/soc/amd/picasso/acpi.c
index b97b2c2..9d88b37 100644
--- a/src/soc/amd/picasso/acpi.c
+++ b/src/soc/amd/picasso/acpi.c
@@ -31,8 +31,6 @@
    current += acpi_create_madt_ioapic_from_hw((acpi_madt_ioapic_t *)current,
    					   GNB_IO_APIC_ADDR);

-	current = acpi_fill_madt_irqoverride(current);
-
    return current;
 }