Attention is currently required from: Bora Guvendik, Hannah Williams, Jérémy Compostella.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74141 )
Change subject: soc/intel/cmn/pcie: Add ability for SoC to overwrite snoop/no-snoop latency
......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74141/comment/b7af75aa_88cedd14
PS4, Line 7: Add ability for
Allow
https://review.coreboot.org/c/coreboot/+/74141/comment/6c7adc54_21899401
PS4, Line 9: require
requires
https://review.coreboot.org/c/coreboot/+/74141/comment/674437e7_48f52ad4
PS4, Line 10: tolerance, let it overwrite the common code settings.
… in devicetree? Kconfig?
File src/soc/intel/common/block/pcie/pcie.c:
https://review.coreboot.org/c/coreboot/+/74141/comment/21405c96_4fbf4816
PS4, Line 14: __weak
I think, coreboot tries to avoid weak functions.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74141
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic2b9a158d219e6c6e7f6e7f0ae0f093c1183b402
Gerrit-Change-Number: 74141
Gerrit-PatchSet: 4
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Comment-Date: Tue, 04 Apr 2023 10:36:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment