Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48146 )
Change subject: mb/kontron/mal10: Reorder includes alphabetically ......................................................................
mb/kontron/mal10: Reorder includes alphabetically
Signed-off-by: Felix Singer felixsinger@posteo.net Change-Id: I804582f08e52948bbc26116e5bd022e56e84ffe3 --- M src/mainboard/kontron/mal10/bootblock.c M src/mainboard/kontron/mal10/ramstage.c M src/mainboard/kontron/mal10/romstage.c 3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/48146/1
diff --git a/src/mainboard/kontron/mal10/bootblock.c b/src/mainboard/kontron/mal10/bootblock.c index 5c40e2d..b8f4f8f 100644 --- a/src/mainboard/kontron/mal10/bootblock.c +++ b/src/mainboard/kontron/mal10/bootblock.c @@ -1,8 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <bootblock_common.h> -#include <intelblocks/lpc_lib.h> #include <ec/kontron/kempld/kempld.h> +#include <intelblocks/lpc_lib.h> #include <variant/gpio.h>
static void init_cpld(void) diff --git a/src/mainboard/kontron/mal10/ramstage.c b/src/mainboard/kontron/mal10/ramstage.c index f03006a..da32061 100644 --- a/src/mainboard/kontron/mal10/ramstage.c +++ b/src/mainboard/kontron/mal10/ramstage.c @@ -1,8 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <device/device.h> -#include <soc/ramstage.h> #include <carrier/gpio.h> +#include <soc/ramstage.h>
static void init_mainboard(void *chip_info) { diff --git a/src/mainboard/kontron/mal10/romstage.c b/src/mainboard/kontron/mal10/romstage.c index dba78f7..8c56bf9 100644 --- a/src/mainboard/kontron/mal10/romstage.c +++ b/src/mainboard/kontron/mal10/romstage.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <soc/romstage.h> #include <FspmUpd.h> +#include <soc/romstage.h>
void mainboard_memory_init_params(FSPM_UPD *mupd) {
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48146 )
Change subject: mb/kontron/mal10: Reorder includes alphabetically ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48146/2/src/mainboard/kontron/mal10... File src/mainboard/kontron/mal10/ramstage.c:
https://review.coreboot.org/c/coreboot/+/48146/2/src/mainboard/kontron/mal10... PS2, Line 5: #include <soc/ramstage.h> move <carrier/gpio.h> before <device/device.h> for real alphabetically order
Hello Nico Huber, Maxim Polyakov,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48146
to look at the new patch set (#3).
Change subject: mb/kontron/mal10: Reorder includes alphabetically ......................................................................
mb/kontron/mal10: Reorder includes alphabetically
Signed-off-by: Felix Singer felixsinger@posteo.net Change-Id: I804582f08e52948bbc26116e5bd022e56e84ffe3 --- M src/mainboard/kontron/mal10/bootblock.c M src/mainboard/kontron/mal10/ramstage.c M src/mainboard/kontron/mal10/romstage.c 3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/48146/3
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48146 )
Change subject: mb/kontron/mal10: Reorder includes alphabetically ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48146/2/src/mainboard/kontron/mal10... File src/mainboard/kontron/mal10/ramstage.c:
https://review.coreboot.org/c/coreboot/+/48146/2/src/mainboard/kontron/mal10... PS2, Line 5: #include <soc/ramstage.h>
move <carrier/gpio.h> before <device/device. […]
thanks!
Hello build bot (Jenkins), Nico Huber, Maxim Polyakov,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48146
to look at the new patch set (#4).
Change subject: mb/kontron/mal10: Reorder includes alphabetically ......................................................................
mb/kontron/mal10: Reorder includes alphabetically
Signed-off-by: Felix Singer felixsinger@posteo.net Change-Id: I804582f08e52948bbc26116e5bd022e56e84ffe3 --- M src/mainboard/kontron/mal10/bootblock.c M src/mainboard/kontron/mal10/ramstage.c M src/mainboard/kontron/mal10/romstage.c 3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/48146/4
-
Felix Singer (Code Review) -
Frans Hendriks (Code Review)