Attention is currently required from: Martin Roth, Christian Walter, Arthur Heymans.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51975 )
Change subject: security/intel/cbnt/Makefile.inc: Use variables for hash alg
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
File src/security/intel/cbnt/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/51975/comment/95b9d497_a5fd4975
PS2, Line 5: ®
Jenkins hates the ® for some reason.
https://review.coreboot.org/c/coreboot/+/51975/comment/e1ac08aa_c2642fba
PS2, Line 6: 558294
document number 558294
https://review.coreboot.org/c/coreboot/+/51975/comment/b544a08e_72f3d076
PS2, Line 8: PK_HASH_ALG_SHA1:=4
nit: keep the values numerically sorted?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51975
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4113b1496e99c10017fc1d85a4acbbc16d32ea41
Gerrit-Change-Number: 51975
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 07 May 2021 12:33:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment