Attention is currently required from: Raul Rangel, Jon Murphy, Karthik Ramasubramanian, Mark Hasemeyer.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74095 )
Change subject: mb/google/myst: First pass GPIO configuration for Myst ......................................................................
Patch Set 7:
(7 comments)
File src/mainboard/google/myst/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/74095/comment/5f252ec1_8acab6b3 PS7, Line 17: GPIO_3 GPIO_7
https://review.coreboot.org/c/coreboot/+/74095/comment/5ece33b7_a7d92305 PS7, Line 22: EN_PWR_WWAN_X `EN_PP3300_WWAN_X`
https://review.coreboot.org/c/coreboot/+/74095/comment/f8ca9d6d_f20a09fc PS7, Line 32: WWAN_RST_L This is listed as just `WWAN_RST`, no `_L`.
https://review.coreboot.org/c/coreboot/+/74095/comment/29083b79_4620f750 PS7, Line 33: HIGH Update this to `LOW`, since this is not active low (assuming documentation is correct).
https://review.coreboot.org/c/coreboot/+/74095/comment/ebd00c00_5ae08654 PS7, Line 39: EC_SOC_WAKE_R_L `EC_SOC_WAKE_R_ODL`
https://review.coreboot.org/c/coreboot/+/74095/comment/8d461ed9_dafc8392 PS7, Line 80: /* ESPI1_DATA2 */ : PAD_NF(GPIO_68, SPI1_DAT2, PULL_NONE), : /* ESPI1_DATA3 */ : PAD_NF(GPIO_69, SPI1_DAT3, PULL_NONE), These are not defined in go/myst-gpios.
https://review.coreboot.org/c/coreboot/+/74095/comment/ba21d2f4_864bce69 PS7, Line 116: /* SPI_SOC_DO_TCHSCR_DO_R */ : PAD_NF(GPIO_105, SPI2_DAT1, PULL_NONE), Not defined in go/myst-gpios.
-
Tim Van Patten (Code Review)