Attention is currently required from: Nico Huber, Karthik Ramasubramanian. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49411 )
Change subject: mb/google/octopus: do LPC/eSPI pad configuration at board-level ......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/google/octopus/bootblock.c:
https://review.coreboot.org/c/coreboot/+/49411/comment/084233f3_60a0446e PS1, Line 13: pads = variant_early_bootblock_gpio_table(&num);
Maybe also not a bad idea to give it a name that relates to its purpose, […]
the early_bootblock table will be moved to bootblock_mainboard_early_init in CB:49426 to also configure uart pads. `_pre_ec_gpio_table` sound like "could be also moved down. early_bootblock_gpio_table at least gives a hint that it belongs there
File src/mainboard/google/octopus/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/49411/comment/6e947bf2_bd454d9f PS1, Line 15: const struct pad_config *variant_early_bootblock_gpio_table(size_t *num); : const struct pad_config *variant_early_gpio_table(size_t *num);
Agreed. I'll push a patch that renames them all at once. That's not a big deal.
that was a misunderstanding, so ignore.
see https://review.coreboot.org/c/coreboot/+/49411/comment/51668e76_9aa6851e/ for naming