Attention is currently required from: Jason Glenesk, Raul Rangel, Jason Nien, Matt DeVillier, Martin Roth, Fred Reitberger, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69852 )
Change subject: util/amdfwtool: Deal psp position in flash offset directly ......................................................................
Patch Set 1:
(6 comments)
File util/amdfwtool/amdfwtool.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164176): https://review.coreboot.org/c/coreboot/+/69852/comment/526272a7_0db4dd38 PS1, Line 2328: case 0xFA0000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164176): https://review.coreboot.org/c/coreboot/+/69852/comment/b1416905_0b488103 PS1, Line 2329: case 0xF20000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164176): https://review.coreboot.org/c/coreboot/+/69852/comment/506ee3f1_85b9132b PS1, Line 2330: case 0xE20000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164176): https://review.coreboot.org/c/coreboot/+/69852/comment/47c872cd_8cc3b8aa PS1, Line 2331: case 0xC20000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164176): https://review.coreboot.org/c/coreboot/+/69852/comment/b9d01792_2469bb94 PS1, Line 2332: case 0x820000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164176): https://review.coreboot.org/c/coreboot/+/69852/comment/5eeaeda3_fa8ef2d1 PS1, Line 2333: case 0x20000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment