Change in ...coreboot[master]: mb,sb: Use get_acpi_table_revision()

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33437

Change subject: mb,sb: Use get_acpi_table_revision()
......................................................................

mb,sb: Use get_acpi_table_revision()

Change-Id: Icce0e8c01732ec0d5797554c0c35606686c2b0e7
Signed-off-by: Elyes HAOUAS 
---
M src/mainboard/amd/torpedo/fadt.c
M src/southbridge/intel/i82371eb/fadt.c
M src/southbridge/nvidia/mcp55/fadt.c
3 files changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/33437/1

diff --git a/src/mainboard/amd/torpedo/fadt.c b/src/mainboard/amd/torpedo/fadt.c
index 3400fcb..9d11378 100644
--- a/src/mainboard/amd/torpedo/fadt.c
+++ b/src/mainboard/amd/torpedo/fadt.c
@@ -50,7 +50,7 @@
    memset((void *)fadt, 0, sizeof(acpi_fadt_t));
    memcpy(header->signature, "FACP", 4);
    header->length = sizeof(acpi_fadt_t);
-	header->revision = 1;
+	header->revision = get_acpi_table_revision(FADT);
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);
diff --git a/src/southbridge/intel/i82371eb/fadt.c b/src/southbridge/intel/i82371eb/fadt.c
index 7669761..afe72c0 100644
--- a/src/southbridge/intel/i82371eb/fadt.c
+++ b/src/southbridge/intel/i82371eb/fadt.c
@@ -39,7 +39,7 @@
    memset((void *) fadt, 0, sizeof(acpi_fadt_t));
    memcpy(header->signature, "FACP", 4);
    header->length = sizeof(acpi_fadt_t);
-	header->revision = 1;
+	header->revision = get_acpi_table_revision(FADT);
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);
diff --git a/src/southbridge/nvidia/mcp55/fadt.c b/src/southbridge/nvidia/mcp55/fadt.c
index 6aaa702..d72ad63 100644
--- a/src/southbridge/nvidia/mcp55/fadt.c
+++ b/src/southbridge/nvidia/mcp55/fadt.c
@@ -39,7 +39,7 @@
    memset((void *) fadt, 0, sizeof(acpi_fadt_t));
    memcpy(header->signature, "FACP", 4);
    header->length = sizeof(acpi_fadt_t);
-	header->revision = 1;
+	header->revision = get_acpi_table_revision(FADT);
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33437 )

Change subject: mb,sb: Use get_acpi_table_revision()
......................................................................

Patch Set 1: Code-Review+1

Change in ...coreboot[master]: src: Use get_acpi_table_revision()

[HAOUAS Elyes (Code Review)]

Hello Angel Pons, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33437

to look at the new patch set (#3).

Change subject: src: Use get_acpi_table_revision()
......................................................................

src: Use get_acpi_table_revision()

Change-Id: Icce0e8c01732ec0d5797554c0c35606686c2b0e7
Signed-off-by: Elyes HAOUAS 
---
M src/mainboard/amd/serengeti_cheetah_fam10/fadt.c
M src/mainboard/amd/torpedo/fadt.c
M src/southbridge/amd/sb700/fadt.c
M src/southbridge/amd/sb800/fadt.c
M src/southbridge/intel/i82371eb/fadt.c
M src/southbridge/intel/lynxpoint/acpi.c
M src/southbridge/nvidia/mcp55/fadt.c
7 files changed, 9 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/33437/3

Change in coreboot[master]: src: Use get_acpi_table_revision()

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33437 )

Change subject: src: Use get_acpi_table_revision()
......................................................................

Abandoned

see https://review.coreboot.org/c/coreboot/+/35540