Attention is currently required from: Sean Rhodes.
Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85711?usp=email )
Change subject: mb/starlabs/starlite_adl: Put options in CFR cbtable ......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/starlabs/starlite_adl/cfr.c:
https://review.coreboot.org/c/coreboot/+/85711/comment/1a8db85a_af5c0e2b?usp... : PS7, Line 320: void lb_board(struct lb_header *header) : { : char *current = (char *)lb_new_record(header); : struct lb_cfr *cfr_root = (struct lb_cfr *)current; : : cfr_write_setup_menu(cfr_root, sm_root); : } should be:
``` void mb_cfr_setup_menu(struct lb_cfr *cfr_root) { cfr_write_setup_menu(cfr_root, sm_root); } ```