Attention is currently required from: Hung-Te Lin, Paul Menzel.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63089 )
Change subject: soc/mediatek/mt8186: Fix pmif setting for low power mode
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63089/comment/e6006f0f_ca6d1c67
PS3, Line 10: which is causing suspend failure
How does it fail exactly?
I add this message in commit message.
The issue of suspend failure is that
SRCLKENA0 will not be pulled down. EC will not be informed AP is
suspending now becuase of this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63089
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2d02198f19f9cb052fba612c02404a6af1a10adb
Gerrit-Change-Number: 63089
Gerrit-PatchSet: 4
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Mon, 28 Mar 2022 10:21:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment