Attention is currently required from: Sathyanarayana Nujella, Sugnan Prabhu S, Paul Menzel, Subrata Banik, Sathya Prakash M R, Tim Wawrzynczak.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51510 )
Change subject: mb/google/brya: Enable display and DSP audio UPD
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
File src/mainboard/google/brya/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/51510/comment/7bbbdc8a_3a0e593d
PS6, Line 75:
nit: Rest of the configs in this file don't use tabs before '='. For consistency, I think we should do the same for audio configs too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51510
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3dab02bedb6df995b1efd27332d3aa26985e188e
Gerrit-Change-Number: 51510
Gerrit-PatchSet: 6
Gerrit-Owner: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sathya Prakash M R
sathya.prakash.m.r@intel.com
Gerrit-CC: Sathyanarayana Nujella
sathyanarayana.nujella@intel.com
Gerrit-Attention: Sathyanarayana Nujella
sathyanarayana.nujella@intel.com
Gerrit-Attention: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Sathya Prakash M R
sathya.prakash.m.r@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Comment-Date: Wed, 21 Apr 2021 20:24:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment