Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/63101 )
Change subject: device/pciexp_device: Set resources for pciexp_hotplug_dummy_ops ......................................................................
device/pciexp_device: Set resources for pciexp_hotplug_dummy_ops
Without setting the set_resources field for pciexp_hotplug_dummy_ops, we will get an error during pciexp_hotplug_dummy.
[ERROR] NONE missing set_resources
Because the set_resources field is considered mandatory, explicitly set it as no-op noop_set_resources.
BUG=b:220639445 TEST=emerge-brya coreboot
Signed-off-by: John Su john_su@compal.corp-partner.google.com Change-Id: Ifee7479c69cf16025dbd4e3924056ed7f8e253cf Reviewed-on: https://review.coreboot.org/c/coreboot/+/63101 Reviewed-by: Eric Lai eric_lai@quanta.corp-partner.google.com Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/device/pciexp_device.c 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved Eric Lai: Looks good to me, but someone else must approve
diff --git a/src/device/pciexp_device.c b/src/device/pciexp_device.c index c525301..3614340 100644 --- a/src/device/pciexp_device.c +++ b/src/device/pciexp_device.c @@ -585,6 +585,7 @@
static struct device_operations pciexp_hotplug_dummy_ops = { .read_resources = pciexp_hotplug_dummy_read_resources, + .set_resources = noop_set_resources, };
void pciexp_hotplug_scan_bridge(struct device *dev)
1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.