Liju-Clr Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69858 )
Change subject: soc/mediatek: Add error handle for dptx_get_edid() ......................................................................
soc/mediatek: Add error handle for dptx_get_edid()
Skip initialization for display when we failed to get EDID.
BUG=b:233720142 TEST=emerge-geralt coreboot.
Change-Id: I0fd672b175feb9b813c1d9ec4140e4273079ff07 Signed-off-by: Liju-Clr Chen liju-clr.chen@mediatek.com --- M src/soc/mediatek/common/dp/dptx.c 1 file changed, 19 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/69858/1
diff --git a/src/soc/mediatek/common/dp/dptx.c b/src/soc/mediatek/common/dp/dptx.c index f2c0905..b836a98 100644 --- a/src/soc/mediatek/common/dp/dptx.c +++ b/src/soc/mediatek/common/dp/dptx.c @@ -1111,7 +1111,10 @@
dptx_check_sinkcap(&mtk_edp);
- dptx_get_edid(&mtk_edp, edid); + if (!dptx_get_edid(&mtk_edp, edid)) { + printk(BIOS_ERR, "Failed to get EDID.\n"); + return -1; + }
dptx_set_trainingstart(&mtk_edp); dp_intf_config(edid);