Attention is currently required from: Tim Wawrzynczak, Sumeet R Pawnikar, Patrick Rudolph.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51397 )
Change subject: soc/intel/alderlake: add processor power limits control support
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51397/comment/9b4f2ffa_df6944da
PS1, Line 14: test
Verified these PL1 and PL2 values using corbeoot logs.
Ack. Can you please add that to the commit message?
File src/soc/intel/alderlake/systemagent.c:
https://review.coreboot.org/c/coreboot/+/51397/comment/9318a2bf_403e2c0f
PS1, Line 63: Configure turbo power limits 1ms after reset complete bit
This delay time is coming as legacy on IA. […]
Strange. I don't see mention of the 1ms delay required between setting of CPL and configuring of turbo power limits in the EDS. What version of the EDS are you looking at? And what is the relevant section #?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51397
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9dc37c7a43e6bd6f1ff5e8a97e22a0c7ac421802
Gerrit-Change-Number: 51397
Gerrit-PatchSet: 1
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 11 Mar 2021 05:46:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-MessageType: comment