Change in coreboot[master]: soc/intel/broadwell/pch: Replace ACPI device NVS

[Tim Wawrzynczak (Code Review)]

Attention is currently required from: Nico Huber, Martin Roth, Angel Pons, Arthur Heymans, Kyösti Mälkki, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52520 )

Change subject: soc/intel/broadwell/pch: Replace ACPI device NVS
......................................................................

Patch Set 3:

(3 comments)

File src/soc/intel/broadwell/pch/acpi.c:

https://review.coreboot.org/c/coreboot/+/52520/comment/a4b2a79d_0c01c2aa 
PS2, Line 18: {
            : 			.type = NAME_STRING,
            : 			.name = SERIALIO_ACPI_PCS,
            : 			.bits = 32,
            : 		};
what about the macro?
`FIELDLIST_NAMESTR(SERIALIO_ACPI_PCS, 32)`

https://review.coreboot.org/c/coreboot/+/52520/comment/3a4b8df7_805c4e0f 
PS2, Line 23: const struct opregion opreg = {
            : 			.name         = "SPRT",
            : 			.regionspace  = SYSTEMMEMORY,
            : 			.regionoffset = bar1 + 0x84,
            : 			.regionlen    = spcs.bits / 8,
            : 		};
You don't like the macros? 😋
`OPREGION("SPRT", SYSTEMMEMORY, bar1 + 0x84, spcs.bits / 8)`
?

File src/soc/intel/broadwell/pch/serialio.c:

https://review.coreboot.org/c/coreboot/+/52520/comment/859df256_f2ae681f 
PS1, Line 19: #include <version.h>
unrelated?