build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29436 )
Change subject: soc/intel/icelake: Add PID based on Icelake EDS
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/29436/1/src/soc/intel/icelake/bootblock/pch....
File src/soc/intel/icelake/bootblock/pch.c:
https://review.coreboot.org/#/c/29436/1/src/soc/intel/icelake/bootblock/pch....
PS1, Line 104: if (pmc_reg_value != 0xFFFFFFFF)
that open brace { should be on the previous line
--
To view, visit
https://review.coreboot.org/29436
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d9e06f06a39dc76a3c1351d7976505d7bd92d10
Gerrit-Change-Number: 29436
Gerrit-PatchSet: 1
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 02 Nov 2018 13:12:37 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No