[M] Change in coreboot[main]: soc/intel/common: Refactor FSP-M early Sign-of-Life (SoL) settings

[Jérémy Compostella (Code Review)]

Jérémy Compostella has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/86532?usp=email )

Change subject: soc/intel/common: Refactor FSP-M early Sign-of-Life (SoL) settings
......................................................................

Patch Set 6:

(1 comment)

Patchset:

PS6: 
After a good night's sleep, I realize that I want to align with your opinion of not pursuing such an endeavor. There is just so much duplication between all the `soc/intel/[...]lake/*` and, in particular, the `fsp_params.c` that it is tempting to find ways to suppress some of them.

As annoying as it is, if we were to look into ways of improving code sharing in this area, I would stay away from the `fsp_params.c` because User Product Data (UPDs) are outside our control. Common code, even if slightly impacted, would quickly become unmanageable.

If we were to start looking into reducing code duplication, and I am all for it, I would recommend starting with `soc/intel/*/pmc.c`, `soc/intel/*/reset.c`, or `soc/intel/*/retimer.c`.