Attention is currently required from: Lance Zhao, Jonathan Zhang. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52734 )
Change subject: acpi: add Generic Initiator Affinity structure for SRAT ......................................................................
Patch Set 1:
(6 comments)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/52734/comment/5a1a4a63_26b9de41 PS1, Line 512: ; remove this
https://review.coreboot.org/c/coreboot/+/52734/comment/43519daa_02c07ff2 PS1, Line 512: u16 seg, u8 bus, u8 dev, u8 func, u32 flags); align this with the previous line
https://review.coreboot.org/c/coreboot/+/52734/comment/3089c3df_ff36f620 PS1, Line 514: 5; /* Generic Initiator Affinity structure */ : gia->length = sizeof(acpi_srat_gia_t); enums or #defines would be nice here instead of magic numbers
https://review.coreboot.org/c/coreboot/+/52734/comment/be7b687f_75065083 PS1, Line 517: 1; /* PCIe device handle */ enums or #defines would be nice here instead of magic numbers
https://review.coreboot.org/c/coreboot/+/52734/comment/30934b86_e34b8532 PS1, Line 521: (((dev) & 0x1F) << 3) `PCI_SLOT(dev)`
https://review.coreboot.org/c/coreboot/+/52734/comment/47d610dd_61b267cc PS1, Line 521: ((func) & 0x07) `PCI_FUNC(func)`
-
Tim Wawrzynczak (Code Review)