Attention is currently required from: Nico Huber, Tarun Tuli, Martin L Roth, Jérémy Compostella, Paul Menzel, Andrey Petrov.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69757 )
Change subject: [RFC] Pull ligfxinit in early romstage ......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69757/comment/70d26084_0d1092ea PS2, Line 9: The goal is to display a text message while memory training is in : progress.
Isn’t that against the goal of coreboot? On what systems does initializing memory take that long (an […]
What is *the* goal of coreboot that this goes against? Homepage says "fast, secure and flexible": we can be fast and flexible by simply making this optional, just like other consoles (flashconsole, EHCI debug, serial port...). And security is something we should always keep in mind no matter what.
This option can be extremely useful for debug purposes, as it would allow one to view coreboot logs without having to do anything special. Also, should one implement open-source RAM init, showing fancy margin art would be a nice way to make up for the long training times. (Well, maybe not everyone finds margin diagrams and the like artistic.)
-
Angel Pons (Code Review)