Attention is currently required from: Angel Pons.
Riku Viitanen has posted comments on this change by Riku Viitanen. ( https://review.coreboot.org/c/coreboot/+/85793?usp=email )
Change subject: nb/sandybridge: Implement automatic DRAM voltage setting ......................................................................
Patch Set 8:
(2 comments)
File src/northbridge/intel/sandybridge/raminit.c:
https://review.coreboot.org/c/coreboot/+/85793/comment/185d92ff_3f59db07?usp... : PS5, Line 197: #define VOLTAGE_MIN 1500 : #define VOLTAGE_MAX 1650 : #define VOLTAGE_DEFAULT 1500
Acknowledged
added the suffix
File src/northbridge/intel/sandybridge/sandybridge.h:
https://review.coreboot.org/c/coreboot/+/85793/comment/14c91c14_abbb1f3e?usp... : PS5, Line 66: optional
Not exactly optional, it has to be implemented if `MAINBOARD_HAS_ADJUSTABLE_DRAM_VOLTAGE` is enabled […]
reworded the comment