Change in coreboot[master]: payloads/external/GRUB2: prevent rebuild without actual changes
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40955 )
Change subject: payloads/external/GRUB2: prevent rebuild without actual changes ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40955/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40955/1//COMMIT_MSG@13 PS1, Line 13: 1. Changed list of included modules (CONFIG_GRUB2_EXTRA_MODULES) Please add a blank line above.
https://review.coreboot.org/c/coreboot/+/40955/1/payloads/external/GRUB2/Mak... File payloads/external/GRUB2/Makefile:
https://review.coreboot.org/c/coreboot/+/40955/1/payloads/external/GRUB2/Mak... PS1, Line 40: grub2: $(CONFIG_DEP) checkout grub2/build/config.h Excuse my ignorance, but why is moving `CONFIG_DEP` fixes the issue?
Squashing the targets `config` and `grub2` is just for cosmetics?
-
Paul Menzel (Code Review)