Attention is currently required from: Rex-BC Chen, Paul Menzel, Yu-Ping Wu.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56106 )
Change subject: vc/mediatek/mt8195: Enable DRAM Vcore DVFS settings
......................................................................
Patch Set 7:
(2 comments)
File src/vendorcode/mediatek/mt8195/dramc/dramc_pi_main.c:
https://review.coreboot.org/c/coreboot/+/56106/comment/bbf21555_2ffa83a4
PS7, Line 275: print("Vio18 = %d\n", dramc_get_vio18_voltage());
please explain why you have to remove this in this patch.
File src/vendorcode/mediatek/mt8195/dramc/dramc_top.c:
https://review.coreboot.org/c/coreboot/+/56106/comment/c2d81b56_bf8e1493
PS7, Line 356: d
%u (vcore is unsigned)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56106
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I39342aea902a87cdc2c5b862e5d1a889fcc822c5
Gerrit-Change-Number: 56106
Gerrit-PatchSet: 7
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Ryan Chuang
ryan.chuang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Fri, 09 Jul 2021 01:54:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment