[S] Change in coreboot[main]: cpu/x86/mtrr: Exclude ranges above 4G if temporary MTRRs exhausted

[Jérémy Compostella (Code Review)]

Attention is currently required from: Matt DeVillier, Shuo Liu.

Jérémy Compostella has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/86941?usp=email )

Change subject: cpu/x86/mtrr: Exclude ranges above 4G if temporary MTRRs exhausted
......................................................................

Patch Set 2:

(6 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/86941/comment/9b28ae95_02686fcc?usp... :
PS2, Line 11:  >
more than

https://review.coreboot.org/c/coreboot/+/86941/comment/1193fd4b_9fb35d6e?usp... :
PS2, Line 17: max available, retry with `above4gb` set to 0.
maximum

File src/cpu/x86/mtrr/mtrr.c:

https://review.coreboot.org/c/coreboot/+/86941/comment/33858af2_375c2060?usp... :
PS2, Line 663: static int calc_var_mtrrs(struct memranges *addr_space,
             : 			  int above4gb, int address_bits, int *num_mtrrs_used)
I would suggest to reflow.

https://review.coreboot.org/c/coreboot/+/86941/comment/75d2499a_184d6d0d?usp... :
PS2, Line 664: int
should be `bool`

https://review.coreboot.org/c/coreboot/+/86941/comment/b0deb01e_56223f10?usp... :
PS2, Line 664: int
size_t

https://review.coreboot.org/c/coreboot/+/86941/comment/979f25cd_95355d99?usp... :
PS2, Line 893: 		sol.mtrr_default_type = calc_var_mtrrs(&addr_space, above4gb, address_bits, &num_mtrrs_used);
Shouldn't you print a message if `num_mtrrs_used > total_mtrrs condition` still isn't met ?