Change in coreboot[master]: mb/google/hatch/var/dratini: Add ElAN touchscreen support

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Chen Wisley (Code Review)

18 Oct 2019 18 Oct '19

8:12 a.m.

Chen Wisley has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36125 )

Change subject: mb/google/hatch/var/dratini: Add ElAN touchscreen support ......................................................................

mb/google/hatch/var/dratini: Add ElAN touchscreen support

Add ELAN EKTH6915 USI touchsreen support.

BUG=b:139392144 TEST=check touchscreen work, and confirmed power sequence with vendor.

Change-Id: I8ebc067bbb407498de00ea0b6c23b0848023cffe Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/hatch/variants/dratini/overridetree.cb 1 file changed, 16 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/36125/1

diff --git a/src/mainboard/google/hatch/variants/dratini/overridetree.cb b/src/mainboard/google/hatch/variants/dratini/overridetree.cb index 8fc33ef..28b18b8 100644 --- a/src/mainboard/google/hatch/variants/dratini/overridetree.cb +++ b/src/mainboard/google/hatch/variants/dratini/overridetree.cb @@ -109,6 +109,22 @@ register "hid_desc_reg_offset" = "0x01" device i2c 5d on end end + chip drivers/i2c/hid + register "generic.hid" = ""ELAN2513"" + register "generic.desc" = ""ELAN Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D16_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" + register "generic.reset_delay_ms" = "20" + register "generic.reset_off_delay_ms" = "2" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D9)" + register "generic.enable_delay_ms" = "10" + register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C4)" + register "generic.stop_delay_ms" = "130" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 15 on end + end end # I2C #1 device pci 15.2 off end # I2C #2 device pci 15.3 off end # I2C #3

Attachments:

attachment.htm (text/html — 4.3 KB)

Show replies by date

Chen Wisley (Code Review)

18 Oct 18 Oct

10:07 a.m.

New subject: Change in coreboot[master]: mb/google/hatch/var/dratini: Add ELAN touchscreen support

Hello Paul Fagerburg, Philip Chen, Tim Wawrzynczak, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36125

to look at the new patch set (#2).

Change subject: mb/google/hatch/var/dratini: Add ELAN touchscreen support ......................................................................

mb/google/hatch/var/dratini: Add ELAN touchscreen support

Add ELAN EKTH6915 USI touchsreen support.

BUG=b:139392144 TEST=check touchscreen work, and confirmed power sequence with vendor.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/36125/2

Paul Fagerburg (Code Review)

3:16 p.m.

New subject: Change in coreboot[master]: mb/google/hatch/var/dratini: Add ELAN touchscreen support

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36125 )

Change subject: mb/google/hatch/var/dratini: Add ELAN touchscreen support ......................................................................

Patch Set 2: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/36125 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8ebc067bbb407498de00ea0b6c23b0848023cffe Gerrit-Change-Number: 36125 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 18 Oct 2019 15:16:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

9:16 p.m.

New subject: Change in coreboot[master]: mb/google/hatch/var/dratini: Add ELAN touchscreen support

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36125 )

Change subject: mb/google/hatch/var/dratini: Add ELAN touchscreen support ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36125/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/dratini/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/36125/2/src/mainboard/google/hatch/... PS2, Line 113: ELAN2513 What driver does this bind to? I don't see ELAN2513 in drivers/input/mouse/elan_i2c_core.c

-- To view, visit https://review.coreboot.org/c/coreboot/+/36125 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8ebc067bbb407498de00ea0b6c23b0848023cffe Gerrit-Change-Number: 36125 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 18 Oct 2019 21:16:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Wisley Chen (Code Review)

19 Oct 19 Oct

12:14 a.m.

New subject: Change in coreboot[master]: mb/google/hatch/var/dratini: Add ELAN touchscreen support

Wisley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36125 )

Change subject: mb/google/hatch/var/dratini: Add ELAN touchscreen support ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36125/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/dratini/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/36125/2/src/mainboard/google/hatch/... PS2, Line 113: ELAN2513

...

What driver does this bind to? I don't see ELAN2513 in drivers/input/mouse/elan_i2c_core. […]

It's use common hid-i2c driver, and doesn't bind to specific driver

-- To view, visit https://review.coreboot.org/c/coreboot/+/36125 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8ebc067bbb407498de00ea0b6c23b0848023cffe Gerrit-Change-Number: 36125 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Comment-Date: Sat, 19 Oct 2019 00:14:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: comment

Wisley Chen (Code Review)

12:14 a.m.

New subject: Change in coreboot[master]: mb/google/hatch/var/dratini: Add ELAN touchscreen support

Wisley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36125 )

Change subject: mb/google/hatch/var/dratini: Add ELAN touchscreen support ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36125/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/dratini/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/36125/2/src/mainboard/google/hatch/... PS2, Line 113: ELAN2513

...

It's use common hid-i2c driver, and doesn't bind to specific driver

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/36125 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8ebc067bbb407498de00ea0b6c23b0848023cffe Gerrit-Change-Number: 36125 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Comment-Date: Sat, 19 Oct 2019 00:14:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Wisley Chen wisley.chen@quanta.corp-partner.google.com Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

6:54 p.m.

New subject: Change in coreboot[master]: mb/google/hatch/var/dratini: Add ELAN touchscreen support

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36125 )

Change subject: mb/google/hatch/var/dratini: Add ELAN touchscreen support ......................................................................

Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/36125/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/dratini/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/36125/2/src/mainboard/google/hatch/... PS2, Line 113: ELAN2513

...

Ack

Thanks for the info!

-- To view, visit https://review.coreboot.org/c/coreboot/+/36125 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8ebc067bbb407498de00ea0b6c23b0848023cffe Gerrit-Change-Number: 36125 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Comment-Date: Sat, 19 Oct 2019 18:54:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Wisley Chen wisley.chen@quanta.corp-partner.google.com Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: comment

Shelley Chen (Code Review)

10:50 p.m.

New subject: Change in coreboot[master]: mb/google/hatch/var/dratini: Add ELAN touchscreen support

Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36125 )

Change subject: mb/google/hatch/var/dratini: Add ELAN touchscreen support ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/36125 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8ebc067bbb407498de00ea0b6c23b0848023cffe Gerrit-Change-Number: 36125 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Comment-Date: Sat, 19 Oct 2019 22:50:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Wisley Chen (Code Review)

20 Oct 20 Oct

2:23 a.m.

New subject: Change in coreboot[master]: mb/google/hatch/var/dratini: Add ELAN touchscreen support

Wisley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36125 )

Change subject: mb/google/hatch/var/dratini: Add ELAN touchscreen support ......................................................................

Patch Set 2:

Hi Shelley/Tim,

Please help to merge it and cherry-pick to chromium TOT.

Thanks

-- To view, visit https://review.coreboot.org/c/coreboot/+/36125 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8ebc067bbb407498de00ea0b6c23b0848023cffe Gerrit-Change-Number: 36125 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Comment-Date: Sun, 20 Oct 2019 02:23:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

2:37 a.m.

New subject: Change in coreboot[master]: mb/google/hatch/var/dratini: Add ELAN touchscreen support

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36125 )

Change subject: mb/google/hatch/var/dratini: Add ELAN touchscreen support ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36125/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/dratini/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/36125/2/src/mainboard/google/hatch/... PS2, Line 123: 130 What is this delay? I don't see it in the datasheet.

-- To view, visit https://review.coreboot.org/c/coreboot/+/36125 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8ebc067bbb407498de00ea0b6c23b0848023cffe Gerrit-Change-Number: 36125 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Comment-Date: Sun, 20 Oct 2019 02:37:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Wisley Chen (Code Review)

4:20 a.m.

New subject: Change in coreboot[master]: mb/google/hatch/var/dratini: Add ELAN touchscreen support

Wisley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36125 )

Change subject: mb/google/hatch/var/dratini: Add ELAN touchscreen support ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36125/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/dratini/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/36125/2/src/mainboard/google/hatch/... PS2, Line 123: 130

...

What is this delay? I don't see it in the datasheet.

in datasheet, from reset to i2c activity need to 300ms. I feel 300 ms is too long. So, I add stop pin delay to 130 ms and make sure the sequence can meet elan's FW requirement with elan fw engineer.

-- To view, visit https://review.coreboot.org/c/coreboot/+/36125 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8ebc067bbb407498de00ea0b6c23b0848023cffe Gerrit-Change-Number: 36125 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Comment-Date: Sun, 20 Oct 2019 04:20:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Wisley Chen (Code Review)

4:22 a.m.

New subject: Change in coreboot[master]: mb/google/hatch/var/dratini: Add ELAN touchscreen support

Wisley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36125 )

Change subject: mb/google/hatch/var/dratini: Add ELAN touchscreen support ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36125/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/dratini/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/36125/2/src/mainboard/google/hatch/... PS2, Line 123: 130

...

in datasheet, from reset to i2c activity need to 300ms. […]

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/36125 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8ebc067bbb407498de00ea0b6c23b0848023cffe Gerrit-Change-Number: 36125 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Comment-Date: Sun, 20 Oct 2019 04:22:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Wisley Chen wisley.chen@quanta.corp-partner.google.com Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Patrick Georgi (Code Review)

21 Oct 21 Oct

9:09 a.m.

New subject: Change in coreboot[master]: mb/google/hatch/var/dratini: Add ELAN touchscreen support

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36125 )

Change subject: mb/google/hatch/var/dratini: Add ELAN touchscreen support ......................................................................

mb/google/hatch/var/dratini: Add ELAN touchscreen support

Add ELAN EKTH6915 USI touchsreen support.

BUG=b:139392144 TEST=check touchscreen work, and confirmed power sequence with vendor.

Change-Id: I8ebc067bbb407498de00ea0b6c23b0848023cffe Signed-off-by: Wisley Chen wisley.chen@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/36125 Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Shelley Chen shchen@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/dratini/overridetree.cb 1 file changed, 16 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Shelley Chen: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved Paul Fagerburg: Looks good to me, but someone else must approve

-- To view, visit https://review.coreboot.org/c/coreboot/+/36125 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8ebc067bbb407498de00ea0b6c23b0848023cffe Gerrit-Change-Number: 36125 Gerrit-PatchSet: 3 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-MessageType: merged

Wisley Chen (Code Review)

2:22 p.m.

New subject: Change in coreboot[master]: mb/google/hatch/var/dratini: Add ELAN touchscreen support

Wisley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36125 )

Change subject: mb/google/hatch/var/dratini: Add ELAN touchscreen support ......................................................................

Patch Set 3:

Please help to cherry-pick to chromuim chromeos-2016.05 . Thanks

-- To view, visit https://review.coreboot.org/c/coreboot/+/36125 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8ebc067bbb407498de00ea0b6c23b0848023cffe Gerrit-Change-Number: 36125 Gerrit-PatchSet: 3 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Comment-Date: Mon, 21 Oct 2019 14:22:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1805

days inactive

1808

days old

coreboot-gerrit@coreboot.org

13 comments

7 participants

tags (0)

participants (7)

Chen Wisley (Code Review)
Furquan Shaikh (Code Review)
Patrick Georgi (Code Review)
Paul Fagerburg (Code Review)
Shelley Chen (Code Review)
Tim Wawrzynczak (Code Review)
Wisley Chen (Code Review)