Change in coreboot[master]: [UNTESTED] mb/amd/mandolin: change EFS SPI mode from 1-4-4 to 1-1-4
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45831 )
Change subject: [UNTESTED] mb/amd/mandolin: change EFS SPI mode from 1-4-4 to 1-1-4 ......................................................................
[UNTESTED] mb/amd/mandolin: change EFS SPI mode from 1-4-4 to 1-1-4
BRANCH=zork
Change-Id: Iad4c922ffcdba4b17e6e81244ff37302eb171d97 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/amd/mandolin/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/45831/1
diff --git a/src/mainboard/amd/mandolin/Kconfig b/src/mainboard/amd/mandolin/Kconfig index 1d2fa5e..63b6306 100644 --- a/src/mainboard/amd/mandolin/Kconfig +++ b/src/mainboard/amd/mandolin/Kconfig @@ -110,7 +110,7 @@ config EFS_SPI_READ_MODE int default 0 if EM100 - default 5 + default 3
config EFS_SPI_SPEED int
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45831 )
Change subject: [UNTESTED] mb/amd/mandolin: change EFS SPI mode from 1-4-4 to 1-1-4 ......................................................................
Patch Set 1: Code-Review+1
Yep, works. Change the commit message and we're good.
Hello build bot (Jenkins), Marshall Dawson,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45831
to look at the new patch set (#2).
Change subject: mb/amd/mandolin: change EFS SPI mode from 1-4-4 to 1-1-4 ......................................................................
mb/amd/mandolin: change EFS SPI mode from 1-4-4 to 1-1-4
BRANCH=zork
Change-Id: Iad4c922ffcdba4b17e6e81244ff37302eb171d97 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/amd/mandolin/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/45831/2
Hello build bot (Jenkins), Marshall Dawson,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45831
to look at the new patch set (#3).
Change subject: mb/amd/mandolin: change EFS SPI mode from 1-4-4 to 1-1-4 ......................................................................
mb/amd/mandolin: change EFS SPI mode from 1-4-4 to 1-1-4
With this change the flash addresses will only get transferred over one data pin like in the non-quad SPI mode and only the data will get sent over all four data pins. Since this gives the flash chip a bit more time to fetch the data the host requested, this allows higher SPI frequencies resulting in a higher throughput when bigger chunks of memory get read.
BRANCH=zork
Change-Id: Iad4c922ffcdba4b17e6e81244ff37302eb171d97 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/amd/mandolin/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/45831/3
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45831 )
Change subject: mb/amd/mandolin: change EFS SPI mode from 1-4-4 to 1-1-4 ......................................................................
Patch Set 3: Code-Review+2
Hello build bot (Jenkins), Marshall Dawson,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45831
to look at the new patch set (#4).
Change subject: mb/amd/mandolin: change EFS SPI mode from 1-4-4 to 1-1-4 ......................................................................
mb/amd/mandolin: change EFS SPI mode from 1-4-4 to 1-1-4
With this change the flash addresses will only get transferred over one data pin like in the non-quad SPI mode and only the data will get sent over all four data pins. Since this gives the flash chip a bit more time to fetch the data the host requested, this allows higher SPI frequencies resulting in a higher throughput when bigger chunks of memory get read.
BRANCH=zork
Change-Id: Iad4c922ffcdba4b17e6e81244ff37302eb171d97 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/amd/mandolin/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/45831/4
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45831 )
Change subject: mb/amd/mandolin: change EFS SPI mode from 1-4-4 to 1-1-4 ......................................................................
mb/amd/mandolin: change EFS SPI mode from 1-4-4 to 1-1-4
With this change the flash addresses will only get transferred over one data pin like in the non-quad SPI mode and only the data will get sent over all four data pins. Since this gives the flash chip a bit more time to fetch the data the host requested, this allows higher SPI frequencies resulting in a higher throughput when bigger chunks of memory get read.
BRANCH=zork
Change-Id: Iad4c922ffcdba4b17e6e81244ff37302eb171d97 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/45831 Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/amd/mandolin/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved
diff --git a/src/mainboard/amd/mandolin/Kconfig b/src/mainboard/amd/mandolin/Kconfig index 1d2fa5e..63b6306 100644 --- a/src/mainboard/amd/mandolin/Kconfig +++ b/src/mainboard/amd/mandolin/Kconfig @@ -110,7 +110,7 @@ config EFS_SPI_READ_MODE int default 0 if EM100 - default 5 + default 3
config EFS_SPI_SPEED int
-
Felix Held (Code Review) -
Marshall Dawson (Code Review)