Attention is currently required from: Martin Roth, Julius Werner, mturney mturney. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49767 )
Change subject: sc7280: aop blob loading changes ......................................................................
Patch Set 21:
(26 comments)
File src/soc/qualcomm/sc7280/aop_load_reset.c:
https://review.coreboot.org/c/coreboot/+/49767/comment/f81d614d_42a29167 PS21, Line 11: bool aop_fw_entry; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/31cb9bdd_c10d8f53 PS21, Line 11: bool aop_fw_entry; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/64f64a91_3e02136f PS21, Line 13: struct prog aop_fw_prog = code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/bd86e79b_f6bb3f1e PS21, Line 13: struct prog aop_fw_prog = please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/44cfe1c0_e737027b PS21, Line 14: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/aop"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/406737d7_eb6d691c PS21, Line 14: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/aop"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/33961802_cd120171 PS21, Line 16: if (prog_locate(&aop_fw_prog)) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/968de0c7_c3d5fec3 PS21, Line 16: if (prog_locate(&aop_fw_prog)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/3bb83734_c65cf448 PS21, Line 17: die("SOC image: AOP_FW not found"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/b18d1b5b_c7ca9ccc PS21, Line 17: die("SOC image: AOP_FW not found"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/b8327747_47b59c7d PS21, Line 19: aop_fw_entry = selfload(&aop_fw_prog); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/fdd5a930_58676ac3 PS21, Line 19: aop_fw_entry = selfload(&aop_fw_prog); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/ff6419c3_115ba847 PS21, Line 20: if (!aop_fw_entry) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/36d1fd63_1a5eba1a PS21, Line 20: if (!aop_fw_entry) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/549a5a1e_031ca8a4 PS21, Line 21: die("SOC image: AOP load failed"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/40017f8f_0a8ec024 PS21, Line 21: die("SOC image: AOP load failed"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/c6584813_b06c1460 PS21, Line 23: clock_reset_aop(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/f616587e_826dbb13 PS21, Line 23: clock_reset_aop(); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/64ea62a4_37a8ef99 PS21, Line 25: printk(BIOS_DEBUG, "\nSOC:AOP brought out of reset.\n"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/d0ee5ae8_16039c35 PS21, Line 25: printk(BIOS_DEBUG, "\nSOC:AOP brought out of reset.\n"); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/mmu.c:
https://review.coreboot.org/c/coreboot/+/49767/comment/adbc730f_4ac75fb8 PS21, Line 25: mmu_config_range((void *)_aop_code_ram, REGION_SIZE(aop_code_ram), CACHED_RAM); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/d1317420_810bf9de PS21, Line 25: mmu_config_range((void *)_aop_code_ram, REGION_SIZE(aop_code_ram), CACHED_RAM); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/e7cc1d39_5427c970 PS21, Line 26: mmu_config_range((void *)_aop_data_ram, REGION_SIZE(aop_data_ram), CACHED_RAM); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/c1521b6b_dd1b0905 PS21, Line 26: mmu_config_range((void *)_aop_data_ram, REGION_SIZE(aop_data_ram), CACHED_RAM); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/soc.c:
https://review.coreboot.org/c/coreboot/+/49767/comment/cdeb87e5_2e358e00 PS21, Line 15: REGION_SIZE(dram_aop) / KiB); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/eddfbabb_4da958fb PS21, Line 15: REGION_SIZE(dram_aop) / KiB); please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)