Change in coreboot[master]: soc/intel: Allow enable/disable ME via CMOS

[Sean Rhodes (Code Review)]

Attention is currently required from:  Felix Singer, Tim Crawford, SRIDHAR SIRICILLA, Furquan Shaikh, Paul Menzel, Rizwan Qureshi, Subrata Banik, Sridhar Siricilla, Arthur Heymans, Evgeny Zinoviev, Patrick Rudolph, Felix Held.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52800 )

Change subject: soc/intel: Allow enable/disable ME via CMOS
......................................................................

Patch Set 86:

(6 comments)

Patchset:

PS81:
> On system76/oryp8, it fails to enable the IME: […]

Done

File src/soc/intel/common/block/cse/cse.c:

https://review.coreboot.org/c/coreboot/+/52800/comment/7e640e43_d4bf60c7 
PS85, Line 1057: int send;
               : 	int result;
> Declare variables at the beginning of that function.

Done

https://review.coreboot.org/c/coreboot/+/52800/comment/4319ce5c_9ae38284 
PS85, Line 1062: 		uint32_t rule_id;
> When setting to Normal mode, the reply does not have a rule_id.

Done

https://review.coreboot.org/c/coreboot/+/52800/comment/e58fc8c3_22cb3b3a 
PS85, Line 1060: struct state_reply {
               : 		struct mkhi_hdr hdr;
               : 		uint32_t rule_id;
               : 	} __packed;
> Not sure about this. I would put this at the beginning too.

That's much better

https://review.coreboot.org/c/coreboot/+/52800/comment/ca62530d_e9640ef4 
PS85, Line 1065: 	struct state_reply reply;
               : 
               : 	size_t reply_size;
> Declare variables at the beginning of that function.

Done

https://review.coreboot.org/c/coreboot/+/52800/comment/66a784e7_9ea99417 
PS85, Line 1109:
> Remove empty line

Done