Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/28393 )
Change subject: mb/lenovo: Dual Graphics for xx20/xx30 ThinkPads ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/28393/2/src/mainboard/lenovo/t430s/romstage.... File src/mainboard/lenovo/t430s/romstage.c:
https://review.coreboot.org/#/c/28393/2/src/mainboard/lenovo/t430s/romstage.... PS2, Line 72: enum hybrid_graphics_req mode = HYBRID_GRAPHICS_INTEGRATED; why not using the hybrid graphics driver ? it looks like the code is the same. Just use:
has_thinker1 = 1 has_panel_hybrid_gpio = 0 has_backlight_gpio = 0
I'm not sure about detect_gpio.
If you want to make sure hybrid_graphics_mode isn't DISCRETE (which can't be set using nvramtool or nvramcui anyway) you could use set_option() here and then call early_hybrid_graphics.
-
Patrick Rudolph (Code Review)