Change in coreboot[master]: mb/google/sarien: Increase Wacom touchscreen reset delay to 120 ms
Casper Chang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34665 )
Change subject: mb/google/sarien: Increase Wacom touchscreen reset delay to 120 ms ......................................................................
mb/google/sarien: Increase Wacom touchscreen reset delay to 120 ms
Increase reset delay to 120ms of touchscreen to meet wacom touchscreen T4 specification and resolve re-bind hid over i2c driver failed after touchscreen firmware auto update.
BUG=b:132211627 TEST=Stress touchscreen firmware auto update 200 times and not found re-bind driver failed.
Change-Id: I488660aefdc6df27077efc7fec2f3b99adbaef9f --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/34665/1
diff --git a/src/mainboard/google/sarien/variants/arcada/devicetree.cb b/src/mainboard/google/sarien/variants/arcada/devicetree.cb index cd19258..1799127 100644 --- a/src/mainboard/google/sarien/variants/arcada/devicetree.cb +++ b/src/mainboard/google/sarien/variants/arcada/devicetree.cb @@ -316,7 +316,7 @@ register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C23_IRQ)" register "generic.probed" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E7)" - register "generic.reset_delay_ms" = "20" + register "generic.reset_delay_ms" = "120" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B21)" register "generic.enable_delay_ms" = "55" register "generic.has_power_resource" = "1"
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34665
to look at the new patch set (#2).
Change subject: mb/google/sarien: Increase Wacom touchscreen reset delay to 120 ms ......................................................................
mb/google/sarien: Increase Wacom touchscreen reset delay to 120 ms
Increase reset delay to 120ms of touchscreen to meet wacom touchscreen T4 specification and resolve re-bind hid over i2c driver failed after touchscreen firmware auto update.
BUG=b:132211627 TEST=Stress touchscreen firmware auto update 200 times and not found re-bind driver failed.
Signed-off-by: Casper Chang casper_chang@wistron.corp-partner.google.com Change-Id: I488660aefdc6df27077efc7fec2f3b99adbaef9f --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/34665/2
Mike Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34665 )
Change subject: mb/google/sarien: Increase Wacom touchscreen reset delay to 120 ms ......................................................................
Patch Set 2: Code-Review+1
Nick Crews has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34665 )
Change subject: mb/google/sarien: Increase Wacom touchscreen reset delay to 120 ms ......................................................................
Patch Set 2: Code-Review+1
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34665 )
Change subject: mb/google/sarien: Increase Wacom touchscreen reset delay to 120 ms ......................................................................
Patch Set 2: Code-Review+2
Duncan Laurie has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34665 )
Change subject: mb/google/sarien: Increase Wacom touchscreen reset delay to 120 ms ......................................................................
mb/google/sarien: Increase Wacom touchscreen reset delay to 120 ms
Increase reset delay to 120ms of touchscreen to meet wacom touchscreen T4 specification and resolve re-bind hid over i2c driver failed after touchscreen firmware auto update.
BUG=b:132211627 TEST=Stress touchscreen firmware auto update 200 times and not found re-bind driver failed.
Signed-off-by: Casper Chang casper_chang@wistron.corp-partner.google.com Change-Id: I488660aefdc6df27077efc7fec2f3b99adbaef9f Reviewed-on: https://review.coreboot.org/c/coreboot/+/34665 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Mike Hsieh mike_hsieh@wistron.corp-partner.google.com Reviewed-by: Nick Crews ncrews@google.com Reviewed-by: Duncan Laurie dlaurie@chromium.org --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved Mike Hsieh: Looks good to me, but someone else must approve Nick Crews: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/sarien/variants/arcada/devicetree.cb b/src/mainboard/google/sarien/variants/arcada/devicetree.cb index cd19258..1799127 100644 --- a/src/mainboard/google/sarien/variants/arcada/devicetree.cb +++ b/src/mainboard/google/sarien/variants/arcada/devicetree.cb @@ -316,7 +316,7 @@ register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C23_IRQ)" register "generic.probed" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E7)" - register "generic.reset_delay_ms" = "20" + register "generic.reset_delay_ms" = "120" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B21)" register "generic.enable_delay_ms" = "55" register "generic.has_power_resource" = "1"
-
Casper Chang (Code Review) -
Duncan Laurie (Code Review)
-
Mike Hsieh (Code Review)
-
Nick Crews (Code Review)