Attention is currently required from: Martin Roth, Stefan Reinauer.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56213 )
Change subject: payloads: FILO: Hook up autoboot options
......................................................................
Patch Set 3:
(3 comments)
Patchset:
PS3:
Assuming this works now?
Yes, at least in my test it did.
PS3:
Should I also hook up the autoboot delay value? (Later on, the path and delay might also be read from CBFS or NVRAM.)
File payloads/external/FILO/Makefile:
https://review.coreboot.org/c/coreboot/+/56213/comment/9ed84d64_12fb93f6
PS2, Line 39: echo "CONFIG_AUTOBOOT_FILE=$(CONFIG_FILO_AUTOBOOT_FILE)" >> filo/.config
Oh it just looks the same because that's almost the default? :) […]
Thank you. That did the trick.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56213
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id167e9a144bf466da87469108002672b299b702a
Gerrit-Change-Number: 56213
Gerrit-PatchSet: 3
Gerrit-Owner: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Wed, 14 Jul 2021 13:45:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment