Attention is currently required from: Anil Kumar K, Eric Lai, Jérémy Compostella, Nick Vaccaro, Subrata Banik.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78502?usp=email )
Change subject: mb/{google,intel}: Update FMD to support CBFS verification ......................................................................
Patch Set 3:
(3 comments)
File src/mainboard/google/dedede/chromeos-dedede-16MiB.fmd:
https://review.coreboot.org/c/coreboot/+/78502/comment/6c753111_2fc227b4 : PS3, Line 10: 0x3a27c0
Just remove the length (both here and below) so that FW_MAIN_A/B takes up all the remaining space? […]
Oh, after reading Julius' comments, I guess it's one or the other. I agree with Julius that just removing the offsets would be better, but I guess that could be done across all platforms in a future commit.
File src/mainboard/google/dedede/chromeos-dedede-32MiB.fmd:
https://review.coreboot.org/c/coreboot/+/78502/comment/e17b3e19_997a0757 : PS3, Line 13: 0x3cffc0
Same, just remove the lengths.
Done
File src/mainboard/intel/jasperlake_rvp/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/78502/comment/a4c05297_161fe240 : PS3, Line 11: @0x2000 0x3a27c0
You get the idea.
Done