Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49811 )
Change subject: soc/amd/picasso/acpi: Add UID for PCI INT devices ......................................................................
soc/amd/picasso/acpi: Add UID for PCI INT devices
We need to have unique UIDs for each device.
BUG=b:175146875 BRANCH=zork TEST=Boot linux, dump ACPI table and verify UIDs are unique
Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: Icd2ccede2b6c2e332157e2eeca89fba14a46b360 --- M src/soc/amd/picasso/acpi/pci_int.asl 1 file changed, 10 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/49811/1
diff --git a/src/soc/amd/picasso/acpi/pci_int.asl b/src/soc/amd/picasso/acpi/pci_int.asl index feaec12..6840758 100644 --- a/src/soc/amd/picasso/acpi/pci_int.asl +++ b/src/soc/amd/picasso/acpi/pci_int.asl @@ -20,10 +20,10 @@ } })
-#define PCI_LINK(DEV_NAME, PIC_REG, APIC_REG) \ +#define PCI_LINK(DEV_NAME, PIC_REG, APIC_REG, UID) \ Device(DEV_NAME) { \ Name(_HID, EISAID("PNP0C0F")) \ - Name(_UID, 1) \ + Name(_UID, UID) \ \ Method(_STA, 0) { \ If (PMOD) { \ @@ -100,11 +100,11 @@ } \ }
-PCI_LINK(INTA, PIRA, IORA) -PCI_LINK(INTB, PIRB, IORB) -PCI_LINK(INTC, PIRC, IORC) -PCI_LINK(INTD, PIRD, IORD) -PCI_LINK(INTE, PIRE, IORE) -PCI_LINK(INTF, PIRF, IORF) -PCI_LINK(INTG, PIRG, IORG) -PCI_LINK(INTH, PIRH, IORH) +PCI_LINK(INTA, PIRA, IORA, 1) +PCI_LINK(INTB, PIRB, IORB, 2) +PCI_LINK(INTC, PIRC, IORC, 3) +PCI_LINK(INTD, PIRD, IORD, 4) +PCI_LINK(INTE, PIRE, IORE, 5) +PCI_LINK(INTF, PIRF, IORF, 6) +PCI_LINK(INTG, PIRG, IORG, 7) +PCI_LINK(INTH, PIRH, IORH, 8)