Attention is currently required from: Raul Rangel, Rob Barnes, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58705 )
Change subject: mb/google/guybrush: Define ACPI Power Resources for FPMCU
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/guybrush/variants/guybrush/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/58705/comment/41be49fb_a5b74aaf
PS1, Line 177: enable_gpio
Do we need to set enable_delay_ms and reset_off_delay_ms? I'm not sure what the timing requirements […]
Referring to CB:37459 and few internal docs:
PowerUp: Assert EN_PWR_FP -> 3 ms delay -> De-assert FPMCU_RST_ODL
Shutdown: De-assert EN_PWR_FP -> Assert FPMCU_RST_ODL
Reboot: Shutdown -> 200 ms delay -> PowerUp
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58705
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I52322eaecf6961ff9a196ca9ab2d58b7d4599d4f
Gerrit-Change-Number: 58705
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-CC: Craig Hesling
hesling@chromium.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 29 Oct 2021 05:35:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment