Attention is currently required from: Michał Żygowski, Nick Vaccaro, Subrata Banik.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78190?usp=email )
Change subject: soc/intel/alderlake: Hook up FSP repo for RPL-P/S
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/alderlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/78190/comment/ffac0c34_554c33ed :
PS1, Line 427: default "3rdparty/fsp/AlderLakeFspBinPkg/Client/AlderLakeS/Fsp.fd" if SOC_INTEL_ALDERLAKE_PCH_S
Actually, this should not be needed anymore if RPL-S FSP is here. We could basically drop ADL-S FSP.
completely agree, but figured that should be a separate patch (along with dropping the now-superfluous vendorcode headers). I wanted this patch to simply add support for using the RPL-U/P binaries/headers in the submodule without changing the behavior for any existing boards/configs.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78190?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ida92d269fcaf6f323599ec174f4dcedbbe65f03c
Gerrit-Change-Number: 78190
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Mon, 02 Oct 2023 14:08:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-MessageType: comment