Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37065 )
Change subject: cpu/x86/lapic/lapic_cpu_init.c: Drop unused guards ......................................................................
cpu/x86/lapic/lapic_cpu_init.c: Drop unused guards
Both model_2065x and model_206ax use the parallel mp init codepath.
Change-Id: I6440d413761361ee8b69d5c76b69409bd7528b5d Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/cpu/x86/lapic/lapic_cpu_init.c 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/37065/1
diff --git a/src/cpu/x86/lapic/lapic_cpu_init.c b/src/cpu/x86/lapic/lapic_cpu_init.c index e7dfc57..ddcfaaa 100644 --- a/src/cpu/x86/lapic/lapic_cpu_init.c +++ b/src/cpu/x86/lapic/lapic_cpu_init.c @@ -143,8 +143,6 @@ return 0; } #if !CONFIG(CPU_AMD_MODEL_10XXX) \ - && !CONFIG(CPU_INTEL_MODEL_206AX) \ - && !CONFIG(CPU_INTEL_MODEL_2065X) mdelay(10); #endif
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37065 )
Change subject: cpu/x86/lapic/lapic_cpu_init.c: Drop unused guards ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37065/1/src/cpu/x86/lapic/lapic_cpu... File src/cpu/x86/lapic/lapic_cpu_init.c:
https://review.coreboot.org/c/coreboot/+/37065/1/src/cpu/x86/lapic/lapic_cpu... PS1, Line 145: #if !CONFIG(CPU_AMD_MODEL_10XXX) \ Trailing \ probably makes this fail build test.
Hello Kyösti Mälkki,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37065
to look at the new patch set (#2).
Change subject: cpu/x86/lapic/lapic_cpu_init.c: Drop unused guards ......................................................................
cpu/x86/lapic/lapic_cpu_init.c: Drop unused guards
Both model_2065x and model_206ax use the parallel mp init codepath.
Change-Id: I6440d413761361ee8b69d5c76b69409bd7528b5d Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/cpu/x86/lapic/lapic_cpu_init.c 1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/37065/2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37065 )
Change subject: cpu/x86/lapic/lapic_cpu_init.c: Drop unused guards ......................................................................
Patch Set 2: Code-Review+2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37065 )
Change subject: cpu/x86/lapic/lapic_cpu_init.c: Drop unused guards ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37065/1/src/cpu/x86/lapic/lapic_cpu... File src/cpu/x86/lapic/lapic_cpu_init.c:
https://review.coreboot.org/c/coreboot/+/37065/1/src/cpu/x86/lapic/lapic_cpu... PS1, Line 145: #if !CONFIG(CPU_AMD_MODEL_10XXX) \
Trailing \ probably makes this fail build test.
Done
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37065 )
Change subject: cpu/x86/lapic/lapic_cpu_init.c: Drop unused guards ......................................................................
Patch Set 2: Code-Review+2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37065 )
Change subject: cpu/x86/lapic/lapic_cpu_init.c: Drop unused guards ......................................................................
Patch Set 2:
Submitting early, this was split from CB:36963 so I consider it 24h old.
Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37065 )
Change subject: cpu/x86/lapic/lapic_cpu_init.c: Drop unused guards ......................................................................
cpu/x86/lapic/lapic_cpu_init.c: Drop unused guards
Both model_2065x and model_206ax use the parallel mp init codepath.
Change-Id: I6440d413761361ee8b69d5c76b69409bd7528b5d Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/37065 Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/cpu/x86/lapic/lapic_cpu_init.c 1 file changed, 1 insertion(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved HAOUAS Elyes: Looks good to me, approved
diff --git a/src/cpu/x86/lapic/lapic_cpu_init.c b/src/cpu/x86/lapic/lapic_cpu_init.c index e7dfc57..ea6a41d 100644 --- a/src/cpu/x86/lapic/lapic_cpu_init.c +++ b/src/cpu/x86/lapic/lapic_cpu_init.c @@ -142,9 +142,7 @@ } return 0; } -#if !CONFIG(CPU_AMD_MODEL_10XXX) \ - && !CONFIG(CPU_INTEL_MODEL_206AX) \ - && !CONFIG(CPU_INTEL_MODEL_2065X) +#if !CONFIG(CPU_AMD_MODEL_10XXX) mdelay(10); #endif
-
Arthur Heymans (Code Review) -
HAOUAS Elyes (Code Review)
-
Kyösti Mälkki (Code Review)