[S] Change in coreboot[master]: vboot: Allow for comparison of hash without zero-padding
Attention is currently required from: Caveh Jalali, Julius Werner, Yu-Ping Wu, Boris Mittelberg.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69762 )
Change subject: vboot: Allow for comparison of hash without zero-padding ......................................................................
Patch Set 6:
(1 comment)
File src/security/vboot/vboot_logic.c:
https://review.coreboot.org/c/coreboot/+/69762/comment/716ed1e8_ae35b0a9 PS5, Line 99: if (slot_hash_sz < saved_hash_sz) {
Not sure why we need to bother checking the extra zeroes?
Hmm. I was thinking about some potential attack strategy which could be used in case when we did not perform full comparison, but after talking to my colleagues about this I think it's pointless and would not make any difference at all.
-
Jakub Czapiga (Code Review)