Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78868?usp=email )
(
1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: soc/intel/cannonlake: Add missing min sleep state for thermal device ......................................................................
soc/intel/cannonlake: Add missing min sleep state for thermal device
Add an entry in the min_pci_sleep_states array for SA_DEVFN_THERMAL, to correct warning in cbmem log: [WARN] unknown min d_state for PCI device 00:12.0
TEST=build/boot google/puff (wyvern), verify warning not present in cbmem log, verify entry for THRM device in ACPI LPI constraint list.
Change-Id: Ide98c1b82c56ed1d34c608f9419f61c8e15d2dab Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/78868 Reviewed-by: Felix Singer service+coreboot-gerrit@felixsinger.de Reviewed-by: Eric Lai ericllai@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/cannonlake/acpi.c 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Eric Lai: Looks good to me, approved
diff --git a/src/soc/intel/cannonlake/acpi.c b/src/soc/intel/cannonlake/acpi.c index ff93e2a..1545d19 100644 --- a/src/soc/intel/cannonlake/acpi.c +++ b/src/soc/intel/cannonlake/acpi.c @@ -170,6 +170,7 @@ { SA_DEVFN_TS, ACPI_DEVICE_SLEEP_D3 }, { SA_DEVFN_IPU, ACPI_DEVICE_SLEEP_D3 }, { SA_DEVFN_GNA, ACPI_DEVICE_SLEEP_D3 }, + { PCH_DEVFN_THERMAL, ACPI_DEVICE_SLEEP_D3 }, { PCH_DEVFN_UFS, ACPI_DEVICE_SLEEP_D3 }, { PCH_DEVFN_GSPI2, ACPI_DEVICE_SLEEP_D3 }, { PCH_DEVFN_ISH, ACPI_DEVICE_SLEEP_D3 },